Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5103 Language and Claim Certification: Implement Claim Certification / Signature Component #84062

Closed
22 of 27 tasks
pacerwow opened this issue May 28, 2024 · 1 comment · Fixed by department-of-veterans-affairs/vets-website#33294
Assignees
Labels
DBEX-TREX Disability Benefits Experience - Team T-Rex disability-experience engineering Engineering topics frontend

Comments

@pacerwow
Copy link
Contributor

pacerwow commented May 28, 2024

As a Veteran, I want to sign ("certify") my form 526 digitally, as this is what I do in the paper form and I want all of the same sections of the paper form present in the digital form.

Background:
The online form is missing the online equivalent to Section IX: Claim certification and signature. It's important to VBA that this be included in the digital form.
Image

Reference

Tasks

  • Add in Claim Certification and Signature component using Platform's Statement of Truth Component
  • Use existing fullNamePath validation for the text input (comes from form.data).
  • Refer to claim certification mapping for reference
  • Enable alerts for unchecked claim certification on the signature component
  • Enable alerts for unmatched signature name on the signature component
  • Ensure error displays with expected name when input name does not match configured name (example in screenshot)
  • All work should be behind a staging environment check

Front end tasks

  • Ensure the page is styled according to design spec.
  • Ensure the back end data from API is displayed in local and review instance
  • Ensure unit tests are available.
  • Ensure your code changes are covered by E2E tests
  • Run axe checks using the Chrome or Firefox browser plugin
  • Test for color contrast and color blindness issues
  • Zoom layouts to 400% at 1280px width
  • Test with 1 or 2 screen readers
  • Navigate using the keyboard only

Acceptance Criteria

  • Scenario: Claim Certification / Signature Component
  • Given the digital form is missing Section IX: Claim certification and signature
  • When the online form includes the Claim Certification/Signature component
  • When Language about Box 1 is changed to have parity with the reintroduced FDC question
  • When this work is controlled by an environment check (same environment check as 5103 Language and Claim Certification: Intro page and Supporting Evidence page #83534)
  • Then this section of the paper form is present in the digital form
  • Designer comments on this issue to approve page styling
  • Unit tests pass
  • E2E tests cover current code and regression
  • End-to-end tests show 0 violations.
  • The data returned matches API response (for given user or scenario)
  • All axe checks pass
  • All color contrast checks pass
  • All zoom testing passes
  • All keyboard checks pass
  • All screenreader checks pass
@pacerwow pacerwow added DBEX-TREX Disability Benefits Experience - Team T-Rex disability-experience frontend backend engineering Engineering topics needs refinement needs further review and discussion at a refinement session labels May 28, 2024
@alatempa24 alatempa24 removed backend needs refinement needs further review and discussion at a refinement session labels May 29, 2024
@pacerwow pacerwow added the needs-refinement Identifies tickets that need to be refined label Jun 26, 2024
@mchae-nava mchae-nava changed the title Implement Claim Certification / Signature Component 5103 - Implement Claim Certification / Signature Component Jul 3, 2024
@pacerwow pacerwow removed the needs-refinement Identifies tickets that need to be refined label Jul 13, 2024
@christinec-fftc christinec-fftc self-assigned this Jul 27, 2024
@pacerwow pacerwow changed the title 5103 - Implement Claim Certification / Signature Component Implement 5103 and Claim Certification / Signature Component Nov 8, 2024
@pacerwow pacerwow changed the title Implement 5103 and Claim Certification / Signature Component Implement Claim Certification / Signature Component Nov 8, 2024
@pacerwow pacerwow added this to the 5103 & Claim Certification milestone Nov 15, 2024
@pacerwow pacerwow removed the on-hold label Nov 19, 2024
@christinec-fftc christinec-fftc changed the title Implement Claim Certification / Signature Component 5103 Language and Claim Certification: Implement Claim Certification / Signature Component Nov 20, 2024
@christinec-fftc christinec-fftc self-assigned this Nov 21, 2024
@christinec-fftc
Copy link
Contributor

  • the difference in links between the Needs Evidence and Privacy Policy is obvious. Let's consider filing a design system improvement to support icon links for opening in new tab
  • concern about the expected name not being announced without going directly to the error message. We may want to file a platform issue for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBEX-TREX Disability Benefits Experience - Team T-Rex disability-experience engineering Engineering topics frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants