Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dbex/84062 claim certification #33294

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Conversation

christinec-fftc
Copy link
Contributor

@christinec-fftc christinec-fftc commented Dec 2, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Adds the claim certification component to the Review page
  • Note: Changes for this feature are all behind environment flags since we are also making changes to the Intro page, which cannot be gated by a toggle. As such, e2e tests will be in a weird state until launch (staging review currently scheduled for 12/17/24). Notes were added in cypress.helpers.js for a temporary workaround on local environments

team: @department-of-veterans-affairs/dbex-trex
toggle cleanup: department-of-veterans-affairs/va.gov-team#96383

Related issue(s)

department-of-veterans-affairs/va.gov-team#84062

Testing done

  • Manual and e2e tests. Verified unit tests are still successful (regression)

Manual test setup

  1. Currently this feature only runs on a local dev environment
  2. Sign in as a test user. Start a new claim, filling out all required fields
  3. Once you get to the Review page, verify the new certification component displays as expected
  4. Leave both the 'Your full name' and certification checkbox fields empty. Verify an error is displayed for the missing name and missing checkbox.
  5. Leave either the name or checkbox empty. Verify appropriate error is displayed
  6. Fill out both name and checkbox. Verify you are able to submit the claim
    fyi: the platform logic that verifies the entered name matches what is in the Veteran's profile strips out whitespace and uses lowercase for the comparison.

Screenshots

desktop mobile
desktop mobile

Error example
claim-certification-error-example

What areas of the site does it impact?

526ez

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/dbex/84062-claim-certification/main December 3, 2024 00:46 Inactive
@christinec-fftc christinec-fftc added the disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) label Dec 3, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/dbex/84062-claim-certification/main December 3, 2024 01:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/dbex/84062-claim-certification/main December 3, 2024 01:47 Inactive
@christinec-fftc christinec-fftc marked this pull request as ready for review December 3, 2024 20:48
@christinec-fftc christinec-fftc requested review from a team as code owners December 3, 2024 20:48
Copy link
Contributor

@aurora-a-k-a-lightning aurora-a-k-a-lightning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@christinec-fftc christinec-fftc merged commit 1e03b1c into main Dec 3, 2024
77 of 80 checks passed
@christinec-fftc christinec-fftc deleted the dbex/84062-claim-certification branch December 3, 2024 22:35
Thrillberg pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5103 Language and Claim Certification: Implement Claim Certification / Signature Component
4 participants