Skip to content

Commit

Permalink
edu-benefits: replace .feature with va-summary-box (#33193)
Browse files Browse the repository at this point in the history
* replace .feature with va-summary-box

* add margin

* update test
  • Loading branch information
jamigibbs authored Dec 3, 2024
1 parent 13e7a47 commit 8475620
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export const eligibilityDescription =
'Have you applied for VA education benefits in the past?';

export const eligibilityInstructions = (
<div className="feature">
<va-summary-box class="vads-u-margin-y--3">
<p>
You’ll also need to complete an Application for VA Education Benefits (VA
Form 22-1990), so we can determine if you qualify for VA education
Expand All @@ -14,5 +14,5 @@ export const eligibilityInstructions = (
We’ll take you to that application after you’ve finished filling out this
one.
</p>
</div>
</va-summary-box>
);
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ import React from 'react';
import { expect } from 'chai';
import sinon from 'sinon';
import { mount } from 'enzyme';
import { ERR_MSG_CSS_CLASS } from '../../../0994/constants';
import {
DefinitionTester,
selectRadio,
} from 'platform/testing/unit/schemaform-utils';
import formConfig from '../../../0994/config/form';
import { ERR_MSG_CSS_CLASS } from '../../constants';
import formConfig from '../../config/form';

describe('VET TEC benefits eligibility', () => {
const page =
Expand All @@ -29,7 +29,7 @@ describe('VET TEC benefits eligibility', () => {
);

selectRadio(form, 'root_appliedForVaEducationBenefits', 'N');
expect(form.find('.feature').length).to.equal(1);
expect(form.find('va-summary-box').length).to.equal(1);
form.unmount();
});

Expand Down
6 changes: 3 additions & 3 deletions src/applications/edu-benefits/10203/content/activeDuty.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import React from 'react';

export const housingPaymentInfo = () => (
// eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex
<div className="feature" tabIndex="0">
<va-summary-box class="vads-u-margin-y--3" tabIndex="0">
You can receive the Rogers STEM Scholarship while you’re on active duty, but
you won’t be eligible for the scholarship's housing allowance.
</div>
you won’t be eligible for the scholarships housing allowance.
</va-summary-box>
);
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,19 @@ export const schoolStudentIdTitle = (
<strong>Your student ID and contact details</strong>
</p>
<p className="school-details-notice">
These details will help us review your application faster, but aren't
These details will help us review your application faster, but arent
required.
</p>
</div>
);

export const stemApplicantSco = (
// eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex
<div className="feature vads-u-margin-top--5" tabIndex="0">
<va-summary-box
class="vads-u-margin-top--5 vads-u-margin-bottom--3"
tabIndex="0"
>
We’ll be reaching out to the School Certifying Official (SCO) at this school
to confirm your eligibility for the scholarship.
</div>
</va-summary-box>
);

0 comments on commit 8475620

Please sign in to comment.