Api 42324 extract intent to file web service bean from local bgs

[mchristiansonVA]

Summary

• This work is behind a feature toggle (flipper): NO
• Moves IntentToFileWebService to its own file.
• Updates v1 & v2 itf controllers and associated rspec tests.

Related issue(s)

• API-42324

Testing done

• New code is covered by unit tests
• Test v1 ITF submit, active, validate
• Test v2 ITF submit, type, vaildate

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 245 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb (+1/-24) modules/claims_api/app/controllers/claims_api/v1/application_controller.rb (+23/-0) modules/claims_api/app/controllers/claims_api/v1/forms/base.rb (+0/-15) modules/claims_api/app/controllers/claims_api/v1/forms/intent_to_file_controller.rb (+3/-3) modules/claims_api/app/controllers/claims_api/v2/application_controller.rb (+8/-0) modules/claims_api/app/controllers/claims_api/v2/veterans/intent_to_file_controller.rb (+3/-3) modules/claims_api/lib/bgs_service/intent_to_file_web_service.rb (+51/-0) modules/claims_api/lib/bgs_service/local_bgs.rb (+0/-43) modules/claims_api/spec/lib/claims_api/find_definition_spec.rb (+0/-22) modules/claims_api/spec/lib/claims_api/local_bgs_proxy_spec.rb (+0/-3) modules/claims_api/spec/lib/claims_api/local_bgs_refactored_spec.rb (+1/-0) modules/claims_api/spec/requests/metadata_spec.rb (+18/-2) modules/claims_api/spec/requests/v1/forms/0966_spec.rb (+5/-5) modules/claims_api/spec/requests/v2/veterans/intent_to_files_spec.rb (+3/-3) modules/claims_api/spec/requests/v2/veterans/rswag_intent_to_file_request_spec.rb (+3/-3) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[rockwellwindsor-va]

@mchristiansonVA I had a similar comment on another PR for this kind of update so just asking here too. Is this a loop because we expect local_bgs_itf_services to grow in the future? I assume the methods can and will grow but will the services?

Perhaps more of a nit really, but just want to understand the changes.