Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vebt 765 - Modify BDN generation to account for holidays #19641

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

alexchan-va
Copy link
Contributor

@alexchan-va alexchan-va commented Nov 27, 2024

Summary

  • This work is behind a feature toggle (flipper): YES/NO No
  • (Summarize the changes that have been made to the platform) Have ingress jobs for BDN skip during holidays
  • (If bug, how to reproduce) N/A
  • (What is the solution, why is this the solution?) Use the holidays gem to account and skip federal holdiays
  • (Which team do you work for, does your team own the maintenance of this component?) VEBT
  • (If introducing a flipper, what is the success criteria being targeted?) N/A

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change The old job ran every weekday and did not skip on holidays
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing Verify that after a holiday, the ingress jobs get skipped
  • If this work is behind a flipper: N/A
    • What is the testing plan for rolling out the feature? Internal testing has been done to simulate that the logic skips the correct dates. Then, when it is rolled out, check after a holiday that the ingress job is not run.
      I have added rspec tests to test the logic whether the logic runs for when it is a holiday vs not a holiday.

Screenshots

Note: Optional

Acceptance criteria

  • [x ] No error nor warning in the console.
  • [x ] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link

github-actions bot commented Dec 2, 2024

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/lib/periodic_jobs_spec.rb

rjohnson2011
rjohnson2011 previously approved these changes Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants