Validate document attachments at time of upload

[danlim715]

Summary

• This work is behind a feature toggle (flipper): NO
• Added benefits intake PDF validation logic for all attachment to run at the time of upload. This change should help catch PDF validation failures before application submission and mitigate failures downstream.
• Pension benefits team to own this work.

Related issue(s)

• Link to ticket created in va.gov-team repo

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/claim_documents/monitor.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/claim_documents/monitor.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/claim_documents/monitor.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/claim_documents/monitor.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/controllers/v0/claim_documents_controller_spec.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/lib/claim_documents/monitor_spec.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/lib/claim_documents/monitor_spec.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/lib/claim_documents/monitor_spec.rb

[TaiWilkin]

Looks like some tests are failing, and one question

[TaiWilkin]

Is this a silent failure? It notifies the user synchronously, right?

[danlim715]

I think this would be considered a silent failure, since submission failures due to attachment failures aren't properly being logged. And no, the similar log_silent_failure_avoided function is the one that sends the email to the user when the parameter email_confirmed: true is passed.

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/support/vcr_cassettes/uploads/validate_document.yml

[github-actions]

1 Warning

⚠️

This PR changes 229 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files .github/CODEOWNERS (+4/-0) app/controllers/v0/claim_documents_controller.rb (+40/-9) app/models/persistent_attachment.rb (+1/-0) config/features.yml (+4/-0) lib/claim_documents/monitor.rb (+25/-0) spec/controllers/v0/claim_documents_controller_spec.rb (+63/-0) spec/lib/claim_documents/monitor_spec.rb (+45/-0) spec/requests/swagger_spec.rb (+20/-18) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger