Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19967: Remove phone toggle post migration #20101

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Dec 16, 2024

Description

Relates to #19967
Relates to #19969

Testing done

Manually
Cypress

Screenshots

QA steps

Set up QA Content Publisher

  • Log in as an admin
  • Assign the following roles to the QA Content Publisher
    • Content publisher
    • Content creator - VAMC
  • Assign the following section to QA Content Publisher
    • Boston VA health care

Check VAMC System Billing and Insurance

  • Log in as QA Content Publisher
  • Go to VAMC System Billing and Insurance
  • Confirm that only one phone number field is present
  • Click edit
  • Confirm that only one phone number field is present

Check VAMC Facility

  • Go to Jamaica Plain VA Medical Center
  • Confirm that only one Mental health phone number is present
  • Click edit
  • Confirm that only one Mental health phone number field is present

Check Staff Profile

  • Go to Jeremiah Elsinger staff profile
  • Confirm that only one phone number is present
  • Click edit
  • Confirm that only one Mental health phone number field is present

Regression tests

  • Cypress
    • health_care_local_facility.feature
      • has a step for adding a Mental health phone number
    • person_profile.feature
      • has a step for adding a phone number

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@omahane omahane requested a review from a team as a code owner December 16, 2024 14:03
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 16, 2024 14:03 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 16, 2024 15:27 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 16, 2024 18:50 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 16, 2024 19:03 Destroyed
Copy link

Checking composer.lock changes...

@omahane
Copy link
Contributor Author

omahane commented Dec 16, 2024

@eselkin I am getting a content-build-gql error in this PR because the query is looking for the old phone number field:

Screenshot of the error

Screenshot 2024-12-16 at 11 27 33 AM

The log file excerpt

20241216-content-build-gql-error.txt

(cc @jilladams @Agile6MSkinner This is blocked until the the content-build issue is resolved)

@eselkin
Copy link
Contributor

eselkin commented Dec 16, 2024

@eselkin I am getting a content-build-gql error in this PR because the query is looking for the old phone number field:

Screenshot of the error

Screenshot 2024-12-16 at 11 27 33 AM ## The log file excerpt [20241216-content-build-gql-error.txt](https://github.com/user-attachments/files/18156211/20241216-content-build-gql-error.txt)

(cc @jilladams @Agile6MSkinner This is blocked until the the content-build issue is resolved)

Maybe it's not in main yet, let me check... Did you release main/main?

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 17, 2024 08:55 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 17, 2024 14:35 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 17, 2024 15:08 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 17, 2024 16:47 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 26, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 27, 2024 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 28, 2024 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 29, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 30, 2024 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 31, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 1, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 2, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 2, 2025 14:02 Destroyed
Copy link

github-actions bot commented Jan 2, 2025

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 3, 2025 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 3, 2025 22:46 Destroyed
Copy link

github-actions bot commented Jan 3, 2025

Checking composer.lock changes...

@omahane omahane requested a review from dsasser January 3, 2025 22:52
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 4, 2025 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 5, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 6, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 6, 2025 13:35 Destroyed
Copy link

github-actions bot commented Jan 6, 2025

Checking composer.lock changes...

Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good (again!).

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 6, 2025 22:51 Destroyed
Copy link

github-actions bot commented Jan 6, 2025

Checking composer.lock changes...

@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-blanditiis

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants