Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAGOV-TEAM-97909: Form Builder Theme #20072

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

ryguyk
Copy link
Contributor

@ryguyk ryguyk commented Dec 10, 2024

Description

This PR implements the beginning of a Form Builder theme. It does a few things:

  1. Defines a Form Builder library.
  2. Creates a base Form Builder css file and connects it to the library.
  3. Imports external VADS token css from UNPKG.
  4. Attaches the two css files from the above two steps to all Form Builder pages.

Note that this PR does not do much to actually implement the design via css. It only sets things up to be able to do that in later work. For now, the only visible change (to prove this works) is to set the font-family at the page level. As seen in the below screenshots, the font was previously sans-serif and is now serif.

Relates to department-of-veterans-affairs/va.gov-team#97909

Testing done

  • Unit test added to confirm css files are being attached to the form pages.
  • Manually inspected page to confirm expected css is applied.

Screenshots

Before

image

After

image

QA steps

  1. Load any Form Builder page
    • Confirm that the font is a serif font.
    • Inspect an element and confirm, specifically, that the css definition is:
    .va-gov-form-builder-page-container {
        font-family: var(--font-family-serif);
    }
    

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing
  • Form Engine

Is this PR blocked by another PR?

  • [] DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@ryguyk ryguyk requested a review from a team as a code owner December 10, 2024 15:56
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 10, 2024 15:56 Destroyed
@ryguyk ryguyk changed the title VAGOV-TEAM-97909: Fform Builder Theme VAGOV-TEAM-97909: Form Builder Theme Dec 10, 2024
Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

Copy link

Checking composer.lock changes...

@github-actions github-actions bot added the DO NOT MERGE Do not merge this PR label Dec 10, 2024
Copy link
Contributor

@derekhouck derekhouck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I verified the theme is applied and the VADS token stylesheet is being imported.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 10, 2024 18:36 Destroyed
Copy link

Checking composer.lock changes...

@ryguyk ryguyk removed the DO NOT MERGE Do not merge this PR label Dec 10, 2024
- Declares a Form Builder library tied to a new css file.
- Imports external VADS token css from UNPKG.
@ryguyk ryguyk force-pushed the VAGOV-TEAM-97909-form-builder-theme branch from 757f68b to 8be2553 Compare December 10, 2024 23:36
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 10, 2024 23:36 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-beatae

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, ACT, TTv5, TT6.a
Description: Ensures buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

@ryguyk ryguyk merged commit fe68c28 into main Dec 11, 2024
18 checks passed
@ryguyk ryguyk deleted the VAGOV-TEAM-97909-form-builder-theme branch December 11, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants