-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAGOV-TEAM-97909: Form Builder Theme #20072
Conversation
GitHub Workflows (.github/workflows/*.yml)Have you...
|
Checking composer.lock changes... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I verified the theme is applied and the VADS token stylesheet is being imported.
Checking composer.lock changes... |
- Declares a Form Builder library tied to a new css file. - Imports external VADS token css from UNPKG.
757f68b
to
8be2553
Compare
Checking composer.lock changes... |
Cypress Accessibility Violations
|
Description
This PR implements the beginning of a Form Builder theme. It does a few things:
Note that this PR does not do much to actually implement the design via css. It only sets things up to be able to do that in later work. For now, the only visible change (to prove this works) is to set the
font-family
at the page level. As seen in the below screenshots, the font was previously sans-serif and is now serif.Relates to department-of-veterans-affairs/va.gov-team#97909
Testing done
Screenshots
Before
After
QA steps
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Form Engine
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?