Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event subscriber to include situation updates for full banner width alerts #16883

Merged
merged 15 commits into from
Jan 30, 2024

Conversation

alexfinnarn
Copy link
Contributor

@alexfinnarn alexfinnarn commented Jan 17, 2024

Description

closes #16781

Testing done

Manually tested as well as added/updated integration tests.

Screenshots

example output at "api/v1/banner-alerts".

Screenshot 2024-01-30 at 11 16 11 AM

QA steps

  1. Edit a "full_width_banner_alert" node
    • Add two situation updates to that node
    • Figure out which path it loads on via the associated VAMC systems
  2. Add a "banner" node that loads at the same path as the "full_width_banner_alert" node you just edited.
  3. Add a "promo_banner" node that loads at the same path as the "full_width_banner_alert" node you just edited.
  4. Go to /api/v1/banner-alerts?path=/your-path
    • Confirm that the "banner" data loads correctly
    • Confirm that the "promo_banner" data loads correctly
    • Confirm that the "full_width_banner_alert" data loads correctly and includes "field_situation_updates" paragraph data either in the "attributes" or "includes" section of the response.
  5. Try not adding a path, /api/v1/banner-alerts, and confirm the response is error: "No path provided.".
  6. Try a path that shouldn't return any data /api/v1/banner-alerts?path=/does-not-exist and confirm that no data is returned. Make sure to check if a promo/banner is set to * and shows on all paths. This might confuse your test since that banner will show even on paths Drupal thinks are 404s...and maybe this should be updated, but it wasn't in the scope of this ticket.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 17, 2024 17:13 Destroyed
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 17, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 17, 2024
Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 17, 2024 18:20 Destroyed
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 17, 2024 18:49 Destroyed
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
docroot/modules/custom/va_gov_api/va_gov_api.module Outdated Show resolved Hide resolved
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 18, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 18, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 18, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 18, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 18, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 18, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 18, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 18, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 19, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 19, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 19, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 19, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 19, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 19, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 19, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 23, 2024 17:04 Destroyed
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 23, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 23, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 23, 2024 18:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 23, 2024 21:54 Destroyed
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 24, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 24, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 24, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 25, 2024 17:46 Destroyed
@github-actions github-actions bot added Accelerated Publishing CMS Team CMS Product team that manages both editor exp and devops labels Jan 30, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 30, 2024 17:17 Destroyed
@alexfinnarn alexfinnarn marked this pull request as ready for review January 30, 2024 18:54
@alexfinnarn alexfinnarn requested a review from a team as a code owner January 30, 2024 18:54
@alexfinnarn alexfinnarn requested a review from tjheffner January 30, 2024 19:01
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 30, 2024 20:24 Destroyed
@tjheffner tjheffner merged commit a04593e into main Jan 30, 2024
23 of 24 checks passed
@tjheffner tjheffner deleted the VACMS-16781-situation-updates branch January 30, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accelerated Publishing CMS Team CMS Product team that manages both editor exp and devops refresh-tugboat-cache Used by GHA Tugboat automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility banner endpoints needs additional data to fully render
4 participants