-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event subscriber to include situation updates for full banner width alerts #16883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 17, 2024
… failures I cannot view
GitHub Workflows (.github/workflows/*.yml)Have you...
|
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 18, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 18, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 18, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 18, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 19, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 19, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 19, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 23, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 24, 2024
docroot/modules/custom/va_gov_api/src/Controller/BannerAlertsController.php
Outdated
Show resolved
Hide resolved
docroot/modules/custom/va_gov_api/src/Controller/BannerAlertsController.php
Outdated
Show resolved
Hide resolved
docroot/modules/custom/va_gov_api/src/Controller/BannerAlertsController.php
Outdated
Show resolved
Hide resolved
github-actions
bot
added
Accelerated Publishing
CMS Team
CMS Product team that manages both editor exp and devops
labels
Jan 30, 2024
tjheffner
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Accelerated Publishing
CMS Team
CMS Product team that manages both editor exp and devops
refresh-tugboat-cache
Used by GHA Tugboat automation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #16781
Testing done
Manually tested as well as added/updated integration tests.
Screenshots
example output at "api/v1/banner-alerts".
QA steps
/api/v1/banner-alerts?path=/your-path
/api/v1/banner-alerts
, and confirm the response iserror: "No path provided."
./api/v1/banner-alerts?path=/does-not-exist
and confirm that no data is returned. Make sure to check if a promo/banner is set to*
and shows on all paths. This might confuse your test since that banner will show even on paths Drupal thinks are 404s...and maybe this should be updated, but it wasn't in the scope of this ticket.Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing