Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update character count status message on "Rich text - 1000 character limit" paragraph type #16805

Closed
wants to merge 2 commits into from

Conversation

davidmpickett
Copy link
Contributor

@davidmpickett davidmpickett commented Jan 10, 2024

Description

Relates to #16659.

#16659 provides new guidance on how the status message on character count status messages should be worded. This PR would update wording on the Paragraph Type: Rich text - 1000 character limit.

This came out of feedback from the VBA Regional Office CMS collab cycle. The Facilities team is using the paragraph type on VBA Centralized Content.

However, the paragraph type is primarily used on Public Websites products:

entity-diagram-paragraph-rich-text-char-limit-1000

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 10, 2024 19:21 Destroyed
@davidmpickett davidmpickett added Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew CMS design system CMS design labels Jan 10, 2024
@davidmpickett davidmpickett changed the title Character count status message Update character count status message on "Rich text - 1000 character limit" paragraph type Jan 10, 2024
@davidmpickett davidmpickett added the Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding label Jan 10, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2024 23:27 Destroyed
@davidmpickett
Copy link
Contributor Author

My first commit only updated the message on the Rich text - 1000 character limit, but this would have led to the Reusable Q&A content type having inconsistent character counters.

My second commit changed the message on the other relevant field.

screencapture-cms-nkglm3lihyk3kzdsun5ced19wysefwxx-ci-cms-va-gov-node-64680-edit-2024-01-11-17_27_48

@davidmpickett
Copy link
Contributor Author

Oh no, this is way more complicated than I originally thought. Centralized Content edit view is very strange. Abandoning this endeavor.

@davidmpickett davidmpickett deleted the character-count-message branch January 11, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS design system CMS design Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants