Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16077: Sets Views Pager Heading Default to H2 #16425

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

tonytaylor
Copy link
Contributor

@tonytaylor tonytaylor commented Dec 14, 2023

Description

Updates patch to set views pager default heading to H2.

Also sets pagination_heading_level on content and orphaned_paragraphs view configurations to use default (was H4).

Relates to #16077

Testing done

Performed manual testing and confirmed the following:

  • all views pagers rendered w/o issue
  • all views that render HTML have the proper H2 heading

Manual testing was performed on the following URLs:

Screenshots

20231214--1034

QA steps

What needs to be checked to prove this works?

  • Go to any of the links above
  • Right-click the pager area and click Inspect
  • The heading adjacent to the pager's unordered list should be h2 - similar to the screenshot above

What needs to be checked to prove it didn't break any related things?

The files modified in this commit only affect pagers.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 14, 2023 13:26 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 14, 2023 13:57 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 14, 2023 14:04 Destroyed
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Dec 14, 2023
@laflannery
Copy link
Contributor

I checked a whole bunch, just selected random ones from the list and they were all H2s. Looks good to me

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 31, 2024 16:15 Destroyed
@edmund-dunn edmund-dunn merged commit 11069bd into main Jan 31, 2024
18 of 19 checks passed
@edmund-dunn edmund-dunn deleted the VACMS-16077-sets-views-pager-default-h2 branch January 31, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants