Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old telephone field numbers from Staff Profiles, B&I, VAMC Facility MH #19969

Open
1 task
Tracked by #19064
jilladams opened this issue Nov 26, 2024 · 3 comments
Open
1 task
Tracked by #19064
Assignees
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide Technical debt Telephone field(s)

Comments

@jilladams
Copy link
Contributor

jilladams commented Nov 26, 2024

Description

In #17854 we standardized around the telephone paragraph field, and moved away from the old telephone field.

When Editor change management is complete (in #19064) we can remove the telephone field from the three places. See below.

Worth doing a sweep of the code to make sure that it is not used elsewhere.

Blocked by #19968

Acceptance criteria

  • Old telephone field is removed from Staff Profiles, Billing & Insurance, and Mental Health
@jilladams
Copy link
Contributor Author

I'm not sure the extent to which this ticket can move. The Telephone field, I think, exists in more places, and I don't know if we can actually remove it from Drupal entirely. It may be that we have just hidden the old field on Staff Profiles / B&I / VAMC Facilities and could now go ahead and remove it from those entities? Drupal folks need to help us know.

@Agile6MSkinner
Copy link

Per @dsasser this is used in other places, so we can't just outright delete it. @laflannery has a list.

@Agile6MSkinner Agile6MSkinner removed the Needs refining Issue status label Dec 4, 2024
@laflannery
Copy link
Contributor

FYI, in case it's needed, the list of fields where the phone number fields are still used is in this ticket

@jilladams jilladams changed the title Remove old telephone field numbers from Drupal Remove old telephone field numbers from Staff Profiles, B&I, VAMC Facility MH Dec 11, 2024
@randimays randimays added Facilities Facilities products (VAMC, Vet Center, etc) and removed Facilities Facilities products (VAMC, Vet Center, etc) labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide Technical debt Telephone field(s)
Projects
None yet
Development

No branches or pull requests

5 participants