-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX Review of updates to VBA Facility content type #14888
Comments
While this is not fully blocked by #14700, it might make sense to wait for that since it will be updating this content type |
@thejordanwood as you review, please look for opportunities to give the editors context for the purpose/intended use of the content and/or link to (coming soon) KB articles
The "Top of page information" heading and "Page introduction" field seem duplicative as they follow the Benefit office overview box (which cannot be edited). |
I've started my UX review in the Figma file and am working on getting feedback. A couple of notes about the ACs:
|
End of sprint update: I started a Slack thread for feedback. I can make any updates to this whenever I get to the CMS collab cycle feedback ticket, so I'm going to call this finished for now. |
@thejordanwood Apologies for my delayed review. I added comments to the Figma - a few areas need your eyes again.
We'll want to include those to ensure the editors can understand how to use the fields and are aware of character counts. |
@thejordanwood FYI we discussed this ticket in sprint planning -- some notes:
|
@jilladams @xiongjaneg Apologies for closing this too early. My original intention was to get all final feedback after making the updates from the CMS collab cycle feedback ticket, but reopening this ticket makes sense too!
|
The design has been updated in the Figma file.
|
This is a big piece of Should feedback about the order of the fields on this form. Might not be necessary to update the Figma file to reflect this, but just pass this along to Drupal folk in their follow up ticket
|
In between the time I made that comment and you picked up this ticket, I worked with our Drupal devs to address this during their implementation, so it was already done. Sorry for any confusion! |
For @aklausmeier 's context when she returns:
(@davidmpickett lemme know if anything there seems wrong to you.) |
Given @swirtSJW's feedback about hiding certain fields based on role not being a good direction, here's an alternate suggestion for the big gray box of uneditable information in Locations and Contact Information:
|
End of sprint update: I've started building out a better mockup to accurately show the suggestions and feedback that are being discussed here. I'll send it back out for feedback within the next couple of days. |
@thejordanwood While you are working on a revised mockup....I added comments in Figma file to Facility page Also, just noting that @mmiddaugh recommended linking back to relevant and helpful KB articles when possible in this comment above. |
@thejordanwood @xiongjaneg FYI chatted with Amanda and updated ACs here based on that convo -- please update if points don't seem right for what's left to do. Also assumed you'd need review from all the same folks - not sure if that's true. |
@aklausmeier @davidmpickett @swirtSJW @omahane I've created a new mockup in the Figma file to show Dave's order suggestions and other updates based on the feedback that's been provided. This is ready for review again. |
@thejordanwood FE and Drupal designs looks good, marking UX review complete |
For end of sprint: Just need to verify if there are any questions left for or from Dave / engineers. If not, can close |
Adding my face to account for reviewing effort |
✅ All my requested edits from the last round were implemented. I left a couple comments about help text, etc, but those are not blockers to closing this ticket |
@xiongjaneg @jilladams Engineers have reviewing this Figma file as an AC in their follow-up ticket, so I don't see any reason to keep this one open. |
User Story or Problem Statement
Review implementation in #14701
Design
Figma file
Tasks
Acceptance Criteria (Sprint 98) - 8 points
Acceptance Criteria (Sprint 99) - 5 points
Acceptance Criteria (Sprint 100) - 5 points
Review with Engineers (may be done at UX sync)Engineering review is first step of Update VBA Facility post-review and collab cycle feedback #16327The text was updated successfully, but these errors were encountered: