fix cognitive complexity #1736
Open
fix cognitive complexity #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Pre File Fetch Sensitivity Check - Verify user and veteran sensitivity levels are compatible. - Add specs and supporting services needed to perform sensitivity level checks. * Implement Banner for Unauthorized Vet Access * Restore Old Error Message Logic
* Gate VBMS Methods with Sensitivity Checks Validate user access to veteran before allowing fetch of veteran data. * Remove Unneeded allow Directives in Spec
* Remove Unneeded Sensitivity Checks Checks are already handled by the sensitive_record method. * Fix Non-Forbidden Banner Styling
…le (#1667) * Pass Sensitivity Check Feature Toggle to UI * Restore Manifest Sensitivity Logic
* Fix User Missing for BGS Sensitivity Check - Update the manifests_controller's refresh method to use the find_or_create_by_user method to find a manifest. This will ensure that the user is set correctly for BGS calls. - Move SensitivityLevelCheckFailure logic to the base_controller. * Fix Misc. Issues - Move rescue_from for BGS errors into the API V1 controller so its existing standard error rescue doesn't catch this exception. - Improve manifests_controller request spec with sensitivity check logic.
- Use new method to check user/veteran sensitivity compatibility in the V2 ApplicationController. - This will prevent the old "use BGS error to verify access" logic from running. Co-authored-by: cacevesva <[email protected]>
* Send Veteran Number in Restart Request * Update Link rel Param
- Remove recently-added frontend logic for setting veteran ID in refresh request as it is unreliable in the way it sets the veteran ID. - Update manifests_controller to set the veteran ID using the manifest as this is much more reliable.
- Gem now returns the JSON body of a HTTP response, so our response parsing code needed to be updated to handle the new format. - Update the VBMS service to alert us of any API responses that can't be parsed so we can troubleshoot them.
- Since the SaveFilesInS3 job is spawned by another job, it does not have access to RequestStore[:current_user] which is needed for verifying veteran/user sensitivity compatibility. - This PR also fixes several Rubocop violations in various files.
* Adjusted UI_EXPIRY_HOURS based on deploy environment * Adjust API HOURS
- Sort output by sensitivity level. - Display total result count for each level.
* Removed send_user feature flag, combined with use_ce_api * Updated vbms service spec * Updated manifest spec for uat expiration hours * send user feature toggle combined with use_ce_api * Combined with ce_api feature toggle * Update failing rspecs * Remove feature flag from method, wrapped method with all ce api calls * wrap ce_api related sensitivity changes * Fix failing specs, reverted to prior code outside of feature flag * update manifest expiry hours to not change in test + non prod * remove pry, reverted to previous test case * If user is blank, return * update front end error handling * Linting * Revert changes
* Change type_description to mapping * Updated rspecs to handle edge case
* pass user info to ceapi * Update specs * update branch name * fix rspec * update claim_evidence_request method * change ref to branch * revert x86 --------- Co-authored-by: youfoundmanesh <[email protected]>
* Add CE API Error Handler Class * Update VBMSService and SensitivityChecker Classes with Error Handling * Update VBMSService with CE API Error Handling * Fix Bad Method Signature * Fix More Spec Failures
- Restore code we know is good. - Wrap in begin/rescue blocks and handle errors there. - Add feature toggle to ApplicationController response so frontend will display banners correctly.
…-affairs/caseflow-efolder into Deepak/fix-code-climate
youfoundmanesh
force-pushed
the
current-user-mgmt
branch
2 times, most recently
from
518200c
to
05a41c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix cognitive complexity
Acceptance Criteria
Testing Plan
User Facing Changes
Code Documentation Updates
Database Changes
Only for Schema Changes
migrate:rollbackworks as desired (changesupported functions)make docs(after runningmake migrate)Integrations: Adding endpoints for external APIs