GH Actions: add linting for GH Action yaml files #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoomlam
force-pushed
the
yoom/lint-gh-actions
branch
from
fbda777
to
2589694
Compare
JaCoCo Test Coverage
|
yoomlam
commented
Sep 6, 2023
| @@ -113,7 +113,7 @@ jobs: | |||
| - name: "API Gateway Rest Controller GET /hello - Validate Response" | |||
| run: | | |||
| # Validate Response: | |||
| if [ "${{ fromJson(steps.apiGatewayHello.outputs.response).data }}" != "Hi!"]; then | |||
| if [ "${{ fromJson(steps.apiGatewayHello.outputs.response).data }}" != "Hi!" ]; then | |||
There was a problem hiding this comment.
fixed bug found by linter
| if: inputs.run_all_tests || steps.changed-files-specific.outputs.any_changed == 'true' | ||
| run: | | ||
| ./gradlew :domain-cc:test | ||
|
|
||
| - name: "Run Employee Experience tests" | ||
| if: inputs.run_all_tests || steps.ee-changed-files-specific.any_changed == 'true' | ||
| if: inputs.run_all_tests || steps.ee-changed-files-specific.outputs.any_changed == 'true' |
There was a problem hiding this comment.
fixed bug found by linter
| type: number | ||
| type: string |
There was a problem hiding this comment.
There is no type number
tcraghu
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
There was not linter to protect from errors in GH Action yaml files
How does this fix it?
Add
lint-gh-actions.ymlthat runs linter to protect from errors in GH Action yaml files.Also fix all the lint problems.
How to test this PR
Ensure all GH Actions continue to work