GH Actions: restrict access to certain GH Actions #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Test Coverage
|
|
These succeed b/c I'm in the VRO-RESTRICTED team:
Note the |
yoomlam
force-pushed
the
develop
branch
3 times, most recently
from
35bd80a
to
9cc027a
Compare
|
Great!. I have verified all the workflows in Yoom's comments. |
tejans24
approved these changes
Sep 8, 2023
Comment on lines
+39
to
+48
| runs-on: ubuntu-latest | ||
| steps: | ||
| - id: checkUserMember | ||
| # Only check for manual runs, not scheduled runs | ||
| if: github.event_name == 'workflow_dispatch' | ||
| uses: tspascoal/get-user-teams-membership@v2 | ||
| with: | ||
| username: ${{ github.actor }} | ||
| team: 'vro-restricted' | ||
| GITHUB_TOKEN: ${{ secrets.ACCESS_TOKEN_READ_TEAM }} |
There was a problem hiding this comment.
Should this be setup as a reusable block?
There was a problem hiding this comment.
I considered that, but there's 2 different versions. Maybe someone can refactor that later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Anyone on the current team are allowed to do potentially dangerous actions, such as deploy to prod, via GH Action workflows.
Associated tickets or Slack threads:
How does this fix it?
Only allow members of the VRO-RESTRICTED team to do potentially dangerous actions.
Affected workflows:
delete-old-releases.ymldelete-published-images.ymldelete-workflow-runs.ymldeploy-secrets.yml- restricted only when deploying toprodupdate-deployment.yml- restricted only when deploying toprodHow to test this PR
If you are not in VRO-RESTRICTED, then the above GH Action workflows should fail (when run on this PR's branch
yoom/restrict-access) with aOnly VRO-RESTRICTED team members can run this actionmessage.