image_template: enable image template version name (oVirt#733)

* image_template: allow to setup template version name Allow to create templates with the same name but with different version by setting up the `template_version_name` variable. Creating a new version requires the base template to exist. If not specified the value of the variable is `base version` which is the default value for base templates. Signed-off-by: Miguel Martín <[email protected]> * image_template: allow to setup template OS and description Allow to setup the template Operative System and the Description. Signed-off-by: Miguel Martín <[email protected]> * Add changelog for oVirt#733 Signed-off-by: Miguel Martín <[email protected]> --------- Signed-off-by: Miguel Martín <[email protected]>
denvist · Dec 12, 2023 · a2a8562 · a2a8562
1 parent d353989
commit a2a8562
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/changelogs/fragments/733-enable-image-template-version-name.yml b/changelogs/fragments/733-enable-image-template-version-name.yml
@@ -0,0 +1,3 @@
+---
+minor_changes:
+      - image_template - Support `template_version_name`, `template_description` and `template_operative_system`. (https://github.com/oVirt/ovirt-ansible-collection/pull/733)
diff --git a/roles/image_template/README.md b/roles/image_template/README.md
@@ -49,6 +49,9 @@ Role Variables
 | glance_image_provider        | UNDEF (mandatory if qcow_url is not used)            | Name of the glance image provider.                    |
 | glance_image            | UNDEF (mandatory if qcow_url is not used)               | This parameter specifies the name of disk in glance provider to be imported as template. |
 | template_prerequisites_tasks | UNDEF | Works only with qcow image. Specify a path to Ansible tasks file, which should be executed on virtual machine before creating a template from it. Note that qcow image must contain guest agent which reports IP address. |
+| template_version_name      | "base version" | Version name of the template. Allows to create different versions of a template.  |
+| template_description       | UNDEF | Sets the template description |
+| template_operating_system  | UNDEF | Sets the template Operative System |
 
 The `template_disks` List of dictionaries can contain following attributes:
 

diff --git a/roles/image_template/defaults/main.yml b/roles/image_template/defaults/main.yml
@@ -16,6 +16,7 @@ template_nics:
     profile_name: ovirtmgmt
     interface: virtio
 template_seal: true
+template_version_name: "base version"
 
 disk_resize_timeout: 60
 disk_storage_domain: null
diff --git a/roles/image_template/tasks/qcow2_image.yml b/roles/image_template/tasks/qcow2_image.yml
@@ -83,7 +83,8 @@
     - name: Check if template already exists
       ovirt_template_info:
         auth: "{{ ovirt_auth }}"
-        pattern: "name={{ template_name }} and datacenter={{ dc_info.ovirt_datacenters[0].name }}"
+        pattern: "name={{ template_name }} and datacenter={{ dc_info.ovirt_datacenters[0].name }}
+          and version_name=\"{{ template_version_name }}\""
       register: template_info
       tags:
         - ovirt-template-image
@@ -230,6 +231,10 @@
         cluster: "{{ template_cluster }}"
         timeout: "{{ template_timeout }}"
         seal: "{{ template_seal }}"
+        version:
+          name: "{{ template_version_name }}"
+        description: "{{ template_description | default(omit)}}"
+        operating_system: "{{ template_operating_system | default(omit)}}"
       when: template_info.ovirt_templates | length == 0
       tags:
         - ovirt-template-image