chore: remove unneeded dependencies #129
Conversation
| verifyVersionAllowNone(crate, "js-sys", versions.jsSys); | ||
| verifyVersionAllowNone(crate, "web-sys", versions.webSys); |
There was a problem hiding this comment.
I believe all of these need to be kept in sync in order to work well with wasm-bindgen?
There was a problem hiding this comment.
I think these all need to be using the same version of wasm-bindgen (ex. web-sys has a dep on wasm-bindgen https://crates.io/crates/web-sys/0.3.69/dependencies). Them getting out of sync causes problems... the wasm-bindgen-cli enforces these checks IIRC. We should probably add a comment here explaining this.
There was a problem hiding this comment.
Tests pass fine, and I wasn't able to find any occurrences of "web-sys" and "wasm-bingen-futures" anywhere besides the versions files. If my understanding is wrong, fair enough. I'll close the PR 🙂
There was a problem hiding this comment.
It might be fine to only enforce the wasm-bindgen version and ensure no duplicates of wasm-bindgen in the cargo metadata: rustwasm/wasm-bindgen#2913 (review)
iuioiua
changed the title
|
Closing in favour of #130. |
This change removes the
wasm-bingen-futuresandweb-sysdependencies, as it seems they are not actually used anywhere.