Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(log): fix level name assertion in LogRecord example #6269

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ryunix
Copy link
Contributor

@ryunix ryunix commented Dec 14, 2024

Hello.

This pull request fixes the assertion in the LogRecord class test to correctly check the level name. The original assertion was checking loggerName, but I believe it should verify levelName instead.

@ryunix ryunix requested a review from kt3k as a code owner December 14, 2024 04:00
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the log label Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (cc9a7c0) to head (2008c66).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6269   +/-   ##
=======================================
  Coverage   96.49%   96.50%           
=======================================
  Files         536      536           
  Lines       41179    41179           
  Branches     6175     6178    +3     
=======================================
+ Hits        39735    39739    +4     
+ Misses       1401     1398    -3     
+ Partials       43       42    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@kt3k kt3k changed the title docs(log): Fix level name assertion in LogRecord test docs(log): fix level name assertion in LogRecord example Dec 16, 2024
@kt3k kt3k merged commit 3698cbd into denoland:main Dec 16, 2024
19 checks passed
@ryunix ryunix deleted the fix-level-name-assertion branch December 16, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants