feat(isolate): guarantee OwnedIsolate layout #1641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses repr(transparent) to ensure OwnedIsolate is a genuine wrapper.
|
|
littledivy
approved these changes
Oct 13, 2024
|
This just contains a pointer to the isolate, why does it need a repr? |
aapoalas
approved these changes
Oct 13, 2024
|
@devsnek In Deno, we do |
|
@littledivy that's not correct. OwnedIsolate implements deref to Isolate methods, which could then be casted from references to pointers without the type cast. |
|
Oh you are right, we do |
|
I made the same assumption as @littledivy did earlier - I didn't notice this was guaranteed in DerefMut. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses repr(transparent) to ensure OwnedIsolate is a genuine wrapper.