Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

docs(getting started) clarify nvim setup instructions #715

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

rawlingsr
Copy link
Contributor

clarify how nvim_lsp variable is set, so it doesn't look like some missing global variable.

clarify how nvim_lsp variable is set, so it doesn't look like some missing global variable in case it has another name
@kt3k
Copy link
Member

kt3k commented Aug 22, 2023

@magurotuna Could you review this change?

@rawlingsr
Copy link
Contributor Author

I would have initially provided more context if I thought it would be helpful. Here's an example of another language server, Rust Analizer, and their neovim specific instructions. Notice they have a variable with the exact same name, and they are doing the same thing with it: reaching inside of lspconfig to run the setup function for their specific language server.

https://github.com/rust-lang/rust/blob/abfc6c44381fb033c6b3b0a6bfb804a799f39afd/src/tools/rust-analyzer/docs/user/manual.adoc#nvim-lsp

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(thanks @skanehira for the advise)

@kt3k kt3k merged commit b56f5d5 into denoland:main Sep 4, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants