fix: remove upstreamed ddoc stylings and update README #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
changed the title
crowlKats
changed the title
donjo
requested changes
Jul 11, 2024
|
|
||
| .ddoc > .toc { | ||
| @apply hidden md:flex md:flex-col !important; | ||
| } |
There was a problem hiding this comment.
The styles here that adjust the ToC position are still necessary because if all of ddoc is in a grid it doesn't anchor the navigation content to the left with a fixed width so I think ddoc should be a flex where the categories list is on the left and the rest of the content takes up the rest of the space.
We could either keep that in here until the next deno_doc pass or migrate it to styles.css as something that is a deno-docs specific interpretation
| > li | ||
| > ul | ||
| > li { | ||
| @apply mt-1 !important; |
There was a problem hiding this comment.
Some of these long document navigation styles should move or else we lose the formatting of the document navigation
donjo
approved these changes
Jul 11, 2024
|
whoops forgot to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved stylings that are deno-docs specific inton the styles.css, and things still in the overrides css file are still to be backported.
deno_doc PR denoland/deno_doc#611