Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating subhosting documentation #436

Merged
merged 15 commits into from
May 8, 2024
Merged

Conversation

thisisjofrank
Copy link
Collaborator

No description provided.

subhosting/manual/index.md Outdated Show resolved Hide resolved
Copy link
Member

@donjo donjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really great! I left a few comments along the way on a few things but this is much more readable and tells a clear story IMO

Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some small comments on source organization.

I would suggest excluding the files that are not yet referenced anywhere and opening a new PR with them instead.

@thisisjofrank thisisjofrank merged commit d889c64 into main May 8, 2024
3 checks passed
@thisisjofrank thisisjofrank deleted the subhosting-docs-update branch May 8, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants