Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs style updates #22

Merged
merged 16 commits into from
Sep 2, 2023
Merged

Docs style updates #22

merged 16 commits into from
Sep 2, 2023

Conversation

donjo
Copy link
Member

@donjo donjo commented Sep 1, 2023

To-do list, roughly in order of priority

Before Shipping

  • remove container wrapper from footer or come up with a new class to wrap all the docs content instead of container so the content itself can sit closer to the navigation (right now container has custom margins and it is used in the footer as well as the docs content
  • fix contrast issue on the global search box in the nav
  • ensure color palette is accessible

Nice to have before shipping

  • try styling the manual/tutorials/api reference in a way that highlights when you're browsing content in that section (currently does it if you are on the overview of tutorials and examples but would be nice to have that active state maintained if you are browsing any content in that section)

Later

  • adjust icons placement/size so they are all visually similar and have the appropriate text baseline next to them
  • replace logo with wordmark verison of logo that includes the word docs

@donjo donjo requested a review from kwhinnery September 1, 2023 19:21
@donjo donjo changed the title [WIP] Docs style updates Docs style updates Sep 1, 2023
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am I supposed to commit this?

@kwhinnery kwhinnery merged commit 0c19582 into main Sep 2, 2023
1 check passed
@kwhinnery kwhinnery deleted the style-update branch September 21, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants