Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new examples section which holds all examples, tutorials and videos #1245

Merged
merged 20 commits into from
Dec 11, 2024
Merged

new examples section which holds all examples, tutorials and videos #1245

merged 20 commits into from
Dec 11, 2024

Conversation

thisisjofrank
Copy link
Collaborator

@thisisjofrank thisisjofrank commented Dec 10, 2024 •
edited
Loading

new examples section which holds all examples, tutorials and videos

Sits under /examples/

image

image

image

image

image

@thisisjofrank thisisjofrank marked this pull request as draft December 10, 2024 00:03
@thisisjofrank thisisjofrank marked this pull request as ready for review December 10, 2024 20:59
ry
ry reviewed Dec 10, 2024
View reviewed changes
examples/_pages/VideoPage.tsx Outdated Show resolved Hide resolved
@ry
Copy link
Member

ry commented Dec 10, 2024

Video pages (like this) are lacking the "Prev" and "Next" links at the bottom

Screenshot 2024-12-10 at 1 38 32 PM

@thisisjofrank
Copy link
Collaborator Author

Video pages (like this) are lacking the "Prev" and "Next" links at the bottom

I'd kind of like to remove the next and prev completely. I don't think they make sense, the content doesn't really flow in an order. What do you think @ry ?

@ry
Copy link
Member

ry commented Dec 10, 2024

I'd kind of like to remove the next and prev completely. I don't think they make sense, the content doesn't really flow in an order. What do you think @ry ?

ya that makes sense

@josh-collinsworth
Visual updates
a5f0950 
- Add more easily visible focus indication to toggle switches
- Stylize contributions section
- Touch up switch transitions and remove unneeded prefixes
josh-collinsworth
josh-collinsworth approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@josh-collinsworth josh-collinsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few small visual updates of my own, just because I was in the repo already and figured it would be easier than writing out comments. Happy to discuss or update if there's an issue. But other than that and one non-blocking comment, LGTM 👍

examples/_pages/examples_test.ts Outdated Show resolved Hide resolved
@josh-collinsworth josh-collinsworth mentioned this pull request Dec 11, 2024
Closed
@thisisjofrank thisisjofrank merged commit efb9265 into main Dec 11, 2024
4 checks passed
@thisisjofrank thisisjofrank deleted the new-examples branch December 11, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@josh-collinsworth josh-collinsworth josh-collinsworth approved these changes

@donjo donjo Awaiting requested review from donjo

@philhawksworth philhawksworth Awaiting requested review from philhawksworth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thisisjofrank @ry @josh-collinsworth @donjo