Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix: Search with google #1233

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Temporary fix: Search with google #1233

merged 5 commits into from
Dec 6, 2024

Conversation

philhawksworth
Copy link
Member

@philhawksworth philhawksworth commented Dec 4, 2024

To help us assess alternatives for a better search experience for visitors with more complete and accurate results, we could direct search requests to a scoped search query on google.

This PR:

  • Replaces the Orama search UI with a new search input which directs the query to Google's search
  • Removes all Orama CSS, JS, and UI components
  • Removes the Orama search index generation tasks from the build
  • Removes any other Orama dependencies

Ideally we'll reinstate Orama once this is optimised suitably and includes all the search results we would expect. Or potentially an alternative service

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approved from a strategic perspective, would like @josh-collinsworth's review on code

@philhawksworth philhawksworth marked this pull request as ready for review December 5, 2024 10:29
@philhawksworth philhawksworth changed the title Search with google Temporary fix: Search with google Dec 5, 2024
Copy link
Contributor

@josh-collinsworth josh-collinsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Serviceable as a temporary fix.

@philhawksworth philhawksworth merged commit 1b6cfec into main Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants