Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy/tutorials/vite.md (Step 2: Run the repo locally) #1187

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

gystemd
Copy link
Contributor

@gystemd gystemd commented Nov 23, 2024

This pull request includes a small change to the deploy/tutorials/vite.md file. The change updates the command to run the project locally from deno task run to deno task dev to reflect the correct usage. The command of step 1 generates a deno.json which defines the following tasks:

"tasks": {
  "dev": "deno run -A --node-modules-dir npm:vite",
  "build": "deno run -A --node-modules-dir npm:vite build",
  "preview": "deno run -A --node-modules-dir npm:vite preview",
  "serve": "deno run --allow-net --allow-read jsr:@std/http@1/file-server dist/"
}, 

the task run does not appear in this list, so the correct one should be dev.

@thisisjofrank thisisjofrank self-requested a review November 25, 2024 09:37
Copy link
Collaborator

@thisisjofrank thisisjofrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! Thank you!

@thisisjofrank thisisjofrank merged commit 199f1b0 into denoland:main Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants