Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check module graph of example scripts #1172

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Nov 21, 2024

This PR adds test cases which check the module graphs of the example scripts are valid.

This prevents the error like #1153 in the future.

@kt3k kt3k requested a review from satyarohith November 21, 2024 10:36
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these automations to prevent similar bugs in the future.

LGTM!

@kt3k kt3k merged commit d0d47e1 into denoland:main Nov 21, 2024
2 checks passed
@kt3k kt3k deleted the check-example-graph branch November 21, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants