refactor: more specific error handling #512
Open
+667
−525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dsherret
reviewed
Aug 12, 2024
# Conflicts: # Cargo.toml # src/graph.rs
crowlKats
commented
Nov 22, 2024
Comment on lines
+182
to
+184
| #[class(generic)] // TODO: maybe inherit? | ||
| #[error(transparent)] | ||
| ContentLoad(Arc<anyhow::Error>), | ||
| ContentLoad(Arc<LoadError>), |
There was a problem hiding this comment.
this and other cases of LoadError currently in deno cli use generic error, however i wonder if this rather should inherit
crowlKats
changed the title
dsherret
reviewed
Dec 3, 2024
Cargo.toml
Outdated
There was a problem hiding this comment.
Can you bump file_test_runner to 0.7.4? Also, let me know when this is ready and I'll take a look.
# Conflicts: # Cargo.lock # Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.