-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: watch exclude flag with watch flag for the directory containing the excluded file #26309
Open
HasanAlrimawi
wants to merge
14
commits into
denoland:main
Choose a base branch
from
HasanAlrimawi:fix-watch-exclude-flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: watch exclude flag with watch flag for the directory containing the excluded file #26309
HasanAlrimawi
wants to merge
14
commits into
denoland:main
from
HasanAlrimawi:fix-watch-exclude-flag
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@HasanAlrimawi thanks for the PR. Do you think you could add a test for this change? |
@bartlomieju Could you help with that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26217
Changes
Problem Root
In
cli/util/file_watcher.rs
this linelet _ = watcher.watch(path, RecursiveMode::Recursive);
.This causes issue if the
path
is directory since this will recursively watch all files and subdirectories, thus the excluded files will be watched if they are within that directory.P.S. I initially tried to solve the issue by: (Failed approaches)
1) Using
watcher.watch()
for every file and folder within the directory and avoiding watching the excluded file and the directory itself, but that will prevent watching any new files made during runtime within the directory.2) Using
watcher.unwatch()
for the excluded file but that didn't work, since the directory is watched. I noticed the same issue tracked in this issue.