fix(ext/node): fix vm memory usage and context initialization #23976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
force-pushed
the
vm_snapshot_context
branch
from
e6b9229 to
22690cd
Compare
littledivy
force-pushed
the
vm_snapshot_context
branch
from
22690cd to
848dabd
Compare
littledivy
added a commit
to denoland/deno_core
that referenced
this pull request
Jun 7, 2024
Remove usage of rusty_v8 annex slots for storing `ContextState` and `ModuleMap` and instead store them directly in a dedicated embedder field. Needed for denoland/deno#23976
This comment was marked as resolved.
This comment was marked as resolved.
littledivy
changed the title
bartlomieju
reviewed
Jun 12, 2024
Comment on lines
+691
to
+700
| // Uncomment for remote debugging | ||
| // { | ||
| // name: "Setup tmate session", | ||
| // if: [ | ||
| // "(matrix.job == 'test' || matrix.job == 'bench') &&", | ||
| // "matrix.profile == 'release' && (matrix.use_sysroot ||", | ||
| // "github.repository == 'denoland/deno')", | ||
| // ].join("\n"), | ||
| // uses: "mxschmitt/action-tmate@v3", | ||
| // }, |
There was a problem hiding this comment.
yes, ive used it quite a few times for segfaults in CIs
| let mut external_references = Vec::with_capacity(7); | ||
| let mut external_references = Vec::with_capacity(14); | ||
|
|
||
| vm::GETTER_MAP_FN.with(|getter| { |
There was a problem hiding this comment.
We should try to remove this thread local hack - maybe the problem is now gone
nathanwhit
pushed a commit
that referenced
this pull request
Jun 13, 2024
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22441
Fixes #23913
Fixes #23852
Fixes #23917