Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip trying to load kind === external #33

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Skip trying to load kind === external #33

merged 2 commits into from
Jan 2, 2025

Conversation

strootje
Copy link
Contributor

@strootje strootje commented Dec 14, 2024 •
edited
Loading

When a module tries to load \0vite/preload-helper.js this module throws an error.

This PR skips trying to load that module with deno and lets vite handle it.

@strootje
Copy link
Contributor Author

@marvinhagemeister Care to review this?

marvinhagemeister
marvinhagemeister approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apologies for the late review, I was on vacation.

@marvinhagemeister marvinhagemeister merged commit 6652456 into denoland:main Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strootje @marvinhagemeister