Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mapped directories in import map not resolved #25

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix: mapped directories in import map not resolved #25

merged 2 commits into from
Nov 27, 2024

Conversation

marvinhagemeister
Copy link
Collaborator

@marvinhagemeister marvinhagemeister commented Nov 27, 2024 •
edited
Loading

Fixes #24
Fixes #23

satyarohith
satyarohith approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 1a986e8 into main Nov 27, 2024
4 checks passed
@marvinhagemeister marvinhagemeister deleted the fix-file-url branch November 27, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith approved these changes

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import map not working Does not work with Vitest Browser Mode
2 participants
@marvinhagemeister @satyarohith