Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tests to Astro 5 #37

Merged
merged 3 commits into from
Dec 9, 2024
Merged

chore: update tests to Astro 5 #37

merged 3 commits into from
Dec 9, 2024

Conversation

irbull
Copy link
Contributor

@irbull irbull commented Dec 3, 2024

Updates the Deno Astro Adapter to Astro 5.0. This includes updating the dependencies in the package.json and removing the warning about static output mode. The static output mode has been removed in Astro 5.0 [1,2].

[1] https://5-0-0-beta--astro-docs-2.netlify.app/en/guides/upgrade-to/v5/#removed-hybrid-rendering-mode
[2] https://astro.build/blog/astro-5/

This change-set also update the README as we can now build with Deno 2.0 This was introduced in commit f8d18fd

This change-set also update the README as we can now build with Deno 2.0
This was introduced in commit f8d18fd
@irbull
Copy link
Contributor Author

irbull commented Dec 4, 2024

Don't review this yet. I've noticed a slight improvement I can make. Astro 5 has removed hybrid support, but this adapter still checks for it.

The `static` output mode has been removed in Astro 5.0 [1,2]. This commit
removes the warning about `static` output mode from the deno astro
adapter.

[1] https://5-0-0-beta--astro-docs-2.netlify.app/en/guides/upgrade-to/v5/#removed-hybrid-rendering-mode
[2] https://astro.build/blog/astro-5/
@irbull
Copy link
Contributor Author

irbull commented Dec 8, 2024

Don't review this yet. I've noticed a slight improvement I can make. Astro 5 has removed hybrid support, but this adapter still checks for it.

Should be good to go now. I removed the check for the static output option as it's the default now that they removed hybrid mode. I left a few links to the docs on this.

@kt3k
Copy link
Member

kt3k commented Dec 9, 2024

Should be good to go now. I removed the check for the static output option as it's the default now that they removed hybrid mode. I left a few links to the docs on this.

Sounds reasonable to me as static mode now seems supporting optional server-side rendering https://astro.build/blog/astro-5/#simplified-prerendering

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit d452225 into denoland:main Dec 9, 2024
2 checks passed
@kt3k
Copy link
Member

kt3k commented Dec 9, 2024

Published as 0.2.0 (minor version bump because of the change of astro major version support) https://www.npmjs.com/package/@deno/astro-adapter/v/0.2.0

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants