-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro 4 update and build fix #11
Conversation
In my opinion you should publish this as a separate package, I think they will never update this package again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh finally, thanks ! |
Hi @matthewp We'd like to publish this change to |
Hey @kt3k, sorry I missed the comment! We'd like to keep the |
Thanks for your reply @matthewp! Ok. Got it. We'll publish it under a different name. |
The update to Astro 4 and the
npm run build
seems to work without issue in this update.I see that the
npm run test
is broken on the main branch and remains broken on this PR. Thetest/helpers.ts
has a hardcoded reference to astro.js which doesn't exist. I imagine this was part of some CI configuration that the previous team had setup and just hasn't been translated over to this repo.