Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose symlinks option for updates on macOS #148

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Expose symlinks option for updates on macOS #148

merged 5 commits into from
Jun 11, 2024

Conversation

dennisvang
Copy link
Owner

@dennisvang dennisvang commented Jun 11, 2024

On macOS, it may be necessary, as in #145, to enable symlinks when files are moved into the app_install_dir using shutil.copytree().

From the shutil.copytree docs:

If symlinks is true, symbolic links in the source tree are represented as symbolic links in the new tree and the metadata of the original links will be copied as far as the platform allows; if false or omitted, the contents and metadata of the linked files are copied to the new tree.

This PR exposes the symlinks argument so user can enable this behavior as follows:

client.download_and_apply_updates(..., symlinks=True)

If not specified, the default setting from shutil.copytree is used, i.e. symlinks=False.

fixes #145

@dennisvang dennisvang merged commit dd4dd8b into master Jun 11, 2024
17 checks passed
@dennisvang dennisvang deleted the issue145 branch June 11, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyInstaller executable does not find Qt WebEngine Process
1 participant