Skip to content

Commit

Permalink
add rudimentary test for process_creation_flags arg
Browse files Browse the repository at this point in the history
  • Loading branch information
dennisvang committed Nov 8, 2023
1 parent e1cb014 commit c21a117
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/tufup/utils/platform_specific.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ def _install_update_win(
# using the process_creation_flags argument
if process_creation_flags is None:
process_creation_flags = subprocess.CREATE_NEW_CONSOLE
else:
logger.debug('using custom process creation flags')
# we use Popen() instead of run(), because the latter blocks execution
subprocess.Popen([script_path], creationflags=process_creation_flags)
logger.debug('exiting')
Expand Down
17 changes: 17 additions & 0 deletions tests/test_utils_platform_specific.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
)

DUMMY_APP_CONTENT = f"""
import subprocess
import sys
sys.path.append('{(BASE_DIR.parent / 'src').as_posix()}')
from tufup.utils.platform_specific import install_update
Expand Down Expand Up @@ -176,6 +177,22 @@ def test_install_update_log_file(self):
log_file_content = log_file_path.read_text()
self.assertTrue(log_file_content)

@unittest.skipIf(
condition=not ON_WINDOWS, reason='process_creation_flags is for windows only'
)
def test_install_update_process_creation_flags(self):
# the log file is only used to verify that the batch file has run successfully
log_file_name = 'install.log'
extra_kwargs_strings = [
'process_creation_flags=subprocess.CREATE_NO_WINDOW',
f'log_file_name="{log_file_name}"',
]
# run the dummy app in a separate process
self.run_dummy_app(extra_kwargs_strings=extra_kwargs_strings)
# a log file should exist
log_file_path = self.dst_dir / log_file_name
self.assertTrue(log_file_path.read_text())

@unittest.skipIf(
condition=not ON_WINDOWS, reason='windows batch files are windows only'
)
Expand Down

0 comments on commit c21a117

Please sign in to comment.