ETQ admin je peux créer une règle de routage de plusieurs lignes #9604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E-L-T
force-pushed
the
etq-admin-je-peux-creer-une-regle-de-routage-de-plusieurs-lignes
branch
20 times, most recently
from
6245eb3 to
450e18b
Compare
E-L-T
force-pushed
the
etq-admin-je-peux-creer-une-regle-de-routage-de-plusieurs-lignes
branch
5 times, most recently
from
63f54e8 to
450cbfd
Compare
E-L-T
force-pushed
the
etq-admin-je-peux-creer-une-regle-de-routage-de-plusieurs-lignes
branch
4 times, most recently
from
3a5d3d0 to
dc2d2fb
Compare
E-L-T
changed the title
LeSim
reviewed
Nov 2, 2023
| @@ -1,11 +1,6 @@ | |||
| class TypesDeChampEditor::ConditionsComponent < ApplicationComponent | |||
| class Conditions::ConditionsComponent < ApplicationComponent | |||
Comment on lines
17
to
30
| - if rows.blank? | ||
| %tr | ||
| %td.far-left= far_left_tag(0) | ||
| %td.target= left_operand_tag(empty, 0) | ||
| %td.operator= operator_tag(EmptyOperator.name, empty, 0) | ||
| %td.value= right_operand_tag(empty, empty, 0) | ||
| %td.delete-column= delete_condition_tag(0) |
There was a problem hiding this comment.
je pense qu'on peut dégager ce cas en initiant avec une condtion EmptyOperator(empty, empty) dans le cas ou le le groupe instructeur n'a pas de routing rule
Comment on lines
42
to
57
| def targeted_champ_changed? | ||
| targeted_champ != groupe_instructeur.routing_rule&.left | ||
| end | ||
|
|
||
| def targeted_champ | ||
| Logic.from_json(params[:targeted_champ]) | ||
| end | ||
|
|
||
| def operator_name | ||
| params[:operator_name] | ||
| end | ||
|
|
||
| def value | ||
| Logic.from_json(params[:value]) | ||
| end | ||
|
|
There was a problem hiding this comment.
est ce qu'on a besoin de ces methodes ?
There was a problem hiding this comment.
Bien vu, on en a plus besoin, je les enlève 👍
LeSim
approved these changes
Nov 2, 2023
| @@ -106,18 +114,24 @@ def other_groupe_instructeurs | |||
|
|
|||
| private | |||
|
|
|||
| def routing_rule_matches_tdc? | |||
| routing_tdc = procedure.active_revision.types_de_champ.find_by(stable_id: routing_rule.left.stable_id) | |||
| def routing_rule_matches_tdc?(rule) | |||
There was a problem hiding this comment.
je ne suis pas sur que cette méthode doit être ici : j'ai l'impression qu'elle sert à savoir si la règle est valide. Or on a besoin de ce même genre de vérification ds les conditions de type de champs. Il doit y avoir de la mutualisation à faire.
There was a problem hiding this comment.
En effet ! Je crois bien que la même logique de validation est déjà implementée dans les méthodes #errors(types_de_champ)des classes du namespace Logic
ça fait un bon bout de code en moins :-) -> 6c959d9
E-L-T
force-pushed
the
etq-admin-je-peux-creer-une-regle-de-routage-de-plusieurs-lignes
branch
4 times, most recently
from
3bc9267 to
9d74711
Compare
…onent inherit from conditions_component
E-L-T
force-pushed
the
etq-admin-je-peux-creer-une-regle-de-routage-de-plusieurs-lignes
branch
from
9d74711 to
3e2e5a0
Compare
E-L-T
force-pushed
the
etq-admin-je-peux-creer-une-regle-de-routage-de-plusieurs-lignes
branch
from
74a0051 to
6c959d9
Compare
E-L-T
deleted the
etq-admin-je-peux-creer-une-regle-de-routage-de-plusieurs-lignes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dans cette PR :
ConditionsComponentAvant
Après (exemple à ne pas reproduire dans sa démarche ;-) c'est pour donner une idée des possibilités)