Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup around champ updates #11110

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tchak
Copy link
Member

@tchak tchak commented Dec 4, 2024

No description provided.

Copy link

sentry-io bot commented Dec 4, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/controllers/attachments_controller.rb

Function Unhandled Issue
destroy [**NoMethodError: undefined method logo' for nil (NoMethodError)**](https://demarches-simplifiees.sentry.io/issues/6099355306/?referrer=github-open-pr-bot) AttachmentsCont... <br> Event Count:` 1

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.96%. Comparing base (fc0f39b) to head (6b8bc4b).

Files with missing lines Patch % Lines
...ponents/editable_champ/editable_champ_component.rb 0.00% 2 Missing ⚠️
app/controllers/attachments_controller.rb 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11110      +/-   ##
==========================================
- Coverage   84.45%   79.96%   -4.49%     
==========================================
  Files        1187     1187              
  Lines       26238    26515     +277     
  Branches     4941     4851      -90     
==========================================
- Hits        22158    21203     -955     
- Misses       4080     5312    +1232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tchak tchak force-pushed the some-cleanup branch 4 times, most recently from 007125b to d748591 Compare December 10, 2024 14:05
@tchak tchak force-pushed the some-cleanup branch 2 times, most recently from acf3bae to 9a1df54 Compare December 18, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant