Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ usager, je veux identifier clairement les alternatives de connexion proposées #10972

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kara22
Copy link
Contributor

@kara22 kara22 commented Oct 21, 2024

@kara22 kara22 marked this pull request as draft October 21, 2024 14:22
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.

Project coverage is 61.53%. Comparing base (1b188f6) to head (60c570a).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
app/controllers/agent_connect/agent_controller.rb 0.00% 21 Missing ⚠️
app/controllers/users/commencer_controller.rb 20.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1b188f6) and HEAD (60c570a). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (1b188f6) HEAD (60c570a)
16 4
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10972       +/-   ##
===========================================
- Coverage   84.40%   61.53%   -22.88%     
===========================================
  Files        1149     1149               
  Lines       25282    27786     +2504     
  Branches     4734     4318      -416     
===========================================
- Hits        21340    17097     -4243     
- Misses       3942    10689     +6747     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kara22 kara22 force-pushed the feat/10917 branch 3 times, most recently from 0a8e570 to dc77d44 Compare October 22, 2024 12:43
@kara22 kara22 marked this pull request as ready for review October 22, 2024 12:44
@kara22 kara22 force-pushed the feat/10917 branch 2 times, most recently from ee983e9 to 430729e Compare October 22, 2024 13:16
@kara22 kara22 requested review from LeSim and colinux October 22, 2024 13:24
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a 2 soucis

  • lorsqu'un professionnel se connecte il a un compte instructeur
  • il faut ajouter le mm système sur la page users/sign_in pour qu'un utilisateur professionnel puisse retrouver son dossier

@kara22
Copy link
Contributor Author

kara22 commented Oct 23, 2024

@colinux sur cette Pr il me reste à définir quand créer l'instructeur en automatique en cas de connexion avec pro connect, et quand le laisser en user simple. Marlène me prpose d'en discuter demain au point UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants