Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Champ related cleanups and refactoring" #10728

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

colinux
Copy link
Member

@colinux colinux commented Aug 30, 2024

@mfo mfo enabled auto-merge August 30, 2024 14:44
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.16%. Comparing base (7693d21) to head (e7443c2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/models/procedure.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10728      +/-   ##
==========================================
- Coverage   84.60%   82.16%   -2.44%     
==========================================
  Files        1119     1119              
  Lines       24756    24910     +154     
  Branches     4612     4582      -30     
==========================================
- Hits        20945    20468     -477     
- Misses       3811     4442     +631     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfo mfo disabled auto-merge August 30, 2024 14:51
@colinux colinux merged commit fb184ce into main Aug 30, 2024
16 of 18 checks passed
@colinux colinux deleted the revert-10711-refactor-champ-related-cleanups branch August 30, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants