Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ Tech, je souhaite pouvoir lancer une tache de migration avec un PG_STATEMENT_TIMEOUT personnalisable #10718

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Aug 27, 2024

No description provided.

Copy link

what-the-diff bot commented Aug 27, 2024

PR Summary

  • Removal of obsolete automated task file
    The file delete_orphaned_champs_with_missing_dossier_task.rb was removed. This was necessary to maintain a clean and efficient codebase.
  • Addition of a task file
    A new file named 20240827085815_delete_orphaned_champs_with_missing_dossier.rake was added in the lib/tasks/deployment directory. The addition of this file aids in the streamlining of deployment tasks.
  • Removal of task-specific test file
    The delete_orphaned_champs_with_missing_dossier_task_spec.rb file was deleted from the spec/tasks/maintenance directory. This was performed as a result of the removal of the corresponding task file.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (0771d20) to head (bab8fc2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10718      +/-   ##
==========================================
- Coverage   84.58%   84.57%   -0.01%     
==========================================
  Files        1119     1118       -1     
  Lines       24767    24753      -14     
  Branches     4615     4611       -4     
==========================================
- Hits        20948    20935      -13     
+ Misses       3819     3818       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfo mfo force-pushed the US/change_delete_orphaned_champs_from_maintenance_task_to_after_party branch 2 times, most recently from 650b7df to 6696a3e Compare August 27, 2024 09:18
…NT_TIMEOUT is not a good fit. change implementation to after_party
@mfo mfo force-pushed the US/change_delete_orphaned_champs_from_maintenance_task_to_after_party branch from 6696a3e to bab8fc2 Compare August 27, 2024 11:43
@mfo mfo added this pull request to the merge queue Aug 27, 2024
Merged via the queue into demarches-simplifiees:main with commit a784b01 Aug 27, 2024
18 checks passed
@mfo mfo deleted the US/change_delete_orphaned_champs_from_maintenance_task_to_after_party branch August 27, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants