ETQ dev, je souhaite que les méthodes de manipulation des répétitions soient consolidées et tiennent compte des projections

[tchak]

No description provided.

[what-the-diff]

PR Summary

• Controller and Preloader updates

  • The dossiers_controller.rb file introduces a line to preload a DossierPreloader.
  • Updates to champ_controller.rb and repetition_controller.rb improve row addition and removal actions by tracking which user made these updates.

• Revised Method Usage

  • Several files, including dossier_type.rb, attestation_template.rb, dossier_champs_concern.rb, and dossier_searchable_concern.rb have been revised to replace champs_for_revision with project_champs_public, project_champs_private and related methods. This alteration aims to improve alignment and consistency across methods.

• Enhancements in Champ Processing

  • Updates in several files, including champ.rb, repetition_champ.rb, and champs_validate_concern.rb, refine how champs are validated, interpreted, and processed, particularly considering if the champ is a repetition and if it is part of the dossier revision.

• Dossier and Procedure Revamps

  • The dossier.rb and procedure.rb files have been adjusted to improve handling of dossiers using newer methods for public and private champs as well as implementing user tracking in updates.

• Improved Serialization and Tests

  • Changes in the champ_serializer.rb file and numerous testing files reflect the wider method updates, ensuring tests remain relevant and effective as code evolves.

• Instruction Button Motivation Update

  • The _instruction_button_motivation.html.haml file has been updated to replace unspecified_annotations_privees and unspecified_champs with unspecified_attestation_champs.partition(&:private?).

• New 'in_dossier_revision?' Checks

  • Several _champ_spec.rb files have had in_dossier_revision? checks added to support expanded champ processing and validation.

This PR endeavors to enhance how the application handles champs and their various contexts, states, and values. Improvements in user tracking also provide greater insight and traceability into champ updates.

[codecov]

Codecov Report

Attention: Patch coverage is 98.63014% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.69%. Comparing base (9167e9a) to head (a8e605f).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
app/models/procedure_revision.rb	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10715   +/-   ##
=======================================
  Coverage   84.68%   84.69%           
=======================================
  Files        1132     1130    -2     
  Lines       25098    25064   -34     
  Branches     4703     4701    -2     
=======================================
- Hits        21255    21228   -27     
+ Misses       3843     3836    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mfo]

1ere passe, c'est canon !

Voici un petit patch pour virer du code mort qui utilisait le DataFixer::DossierChampsMissing
0001-clean-deadcode-remove-deadcode.patch

[mfo]

Spontannément j'aurais inliné la methode dossier.repetition_add_row(type_de_champ, updated_by:) ici (seul appel de cette methode est ici). J'ai l'impression que c'est une indirection de trop, ça me perturbe. T'as voulu collocaliser la gestion des repetitions dans le concern ?

[mfo]

Spontannément j'aurais inliné la methode dossier.repetition_remove_row(type_de_champ, row_id, updated_by:) ici (seul appel de cette methode est ici). J'ai l'impression que c'est une indirection de trop, ça me perturbe. T'as voulu collocaliser la gestion des repetitions dans le concern ?