Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech : amélioration de la gestion des types_de_champ.options #10713

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

Benoit-MINT
Copy link
Contributor

@Benoit-MINT Benoit-MINT commented Aug 23, 2024

le point de départ est l'issue : #10209

Les évolutions :
1- modification de la gestion des drop_down_options en fonction du type de drop_down_list sur une draft procédure visant à soulager l'utilisateur lors du changement du type_champ, pour un même type_de_champ : (i) on garde en mémoire lorsque c'est pertinent les valeurs déjà renseignés, (ii) on réinitialise lorsque c'est pertinent pour mieux illustrer à l'utilisateur la syntaxe attendue ;
2 - lorsque qu'une notice est jointe à un type_de_champ "explication" : on la supprime s'il y a un changement de type_champ sur un même type_de_champ, à l'image de ce qui fait pour piece_justificative et titre_identite ;
3 - front : recadrer le bloc des options ;
4 - modifier la méthode de diff pour supprimer le bug de l'issue liée à character_limit ;
5 - organiser un nettoyage des options des types_de_champ lors de la publication d'une procédure ou d'une nouvelle revision.

@Benoit-MINT Benoit-MINT force-pushed the etq-admin-bug-message-info-character-limit branch from 8fd8589 to 1077ec8 Compare August 27, 2024 09:17
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (5cbdfd8) to head (e88d84c).
Report is 140 commits behind head on main.

Files with missing lines Patch % Lines
app/models/type_de_champ.rb 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10713      +/-   ##
==========================================
- Coverage   84.68%   84.51%   -0.17%     
==========================================
  Files        1130     1141      +11     
  Lines       25060    25273     +213     
  Branches     4704     4724      +20     
==========================================
+ Hits        21221    21360     +139     
- Misses       3839     3913      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Benoit-MINT Benoit-MINT force-pushed the etq-admin-bug-message-info-character-limit branch 3 times, most recently from 3380f34 to 2044f81 Compare August 27, 2024 15:14
@Benoit-MINT Benoit-MINT marked this pull request as ready for review September 2, 2024 15:56
app/models/type_de_champ.rb Outdated Show resolved Hide resolved
app/models/type_de_champ.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@mfo mfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dans cette spec d'annotations_component_spec, on cherche a tester une demarche invalide, le plus simple etant de l'invalider avec une autre erreur non ?

@LeSim LeSim force-pushed the etq-admin-bug-message-info-character-limit branch from 20d5fe1 to 74219c0 Compare October 7, 2024 12:39
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES !

app/models/type_de_champ.rb Show resolved Hide resolved
@Benoit-MINT Benoit-MINT force-pushed the etq-admin-bug-message-info-character-limit branch 2 times, most recently from 1e888dc to 3d311e7 Compare October 15, 2024 12:18
@Benoit-MINT Benoit-MINT force-pushed the etq-admin-bug-message-info-character-limit branch from 3d311e7 to e88d84c Compare October 15, 2024 12:40
@Benoit-MINT Benoit-MINT added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit c8f6928 Oct 15, 2024
18 checks passed
@Benoit-MINT Benoit-MINT deleted the etq-admin-bug-message-info-character-limit branch October 15, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants