-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 7.0 : finalise la migration des defaults #10712
Rails 7.0 : finalise la migration des defaults #10712
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10712 +/- ##
==========================================
- Coverage 84.57% 84.57% -0.01%
==========================================
Files 1118 1119 +1
Lines 24753 24765 +12
Branches 4611 4611
==========================================
+ Hits 20935 20945 +10
- Misses 3818 3820 +2 ☔ View full report in Codecov by Sentry. |
11d136a
to
5859ea4
Compare
|
||
# Remove after all encrypted attributes have been rotated. | ||
legacy_key = ActiveSupport::KeyGenerator.new(password, hash_digest_class: OpenSSL::Digest::SHA1).generate_key(salt, len) | ||
@encryptor.rotate legacy_key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
til: https://api.rubyonrails.org/v7.1.0/classes/ActiveSupport/MessageEncryptor.html – vraiment cool j'avais vraiment pas creusé comme API :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
impeccable ! juste les tests autour de la rotation de encrypt/descrypt ou j'ai l'impression qu'on re-teste le MessageEncryptor de rails, mais a la limite on pourra les faire sauter une fois les cookies rotate et les migrations passées
7c30ab8
On avait attendu à l'époque pour se laisser l'opportunité au cas où de rollback car ces changements sont non rétro compatibles (et on avait jamais finalisé).
Conséquemment :
Procedure#api_particulier_token_
concerné`)On pourra décabler la rotation dans quelques temps.
Les messages signés ne sont pas concernés, la valeur par défaut restant au SHA1.
Testé manuellement :