Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ tech je souhaite que les champs RNA ne puissent pas contenir d'espace sans quoi nos appels d'API remontent un URI::InvalidURIError #10708

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Aug 21, 2024

No description provided.

Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remarque sur le pattern. Ça coûterait pas trop cher de faire pareil sur RNF non ?

app/javascript/controllers/format_controller.ts Outdated Show resolved Hide resolved
@mfo mfo force-pushed the US/format-rna branch 2 times, most recently from a1c2edf to eb92a6a Compare August 22, 2024 07:57
@mfo
Copy link
Contributor Author

mfo commented Aug 22, 2024

@colinux, pas sur de comprendre ta remarque sur reprendre ce pattern pr rnf :

  • par pattern entends tu la validation front/back ?
  • par pattern entends tu le fait de clean les data ?

@colinux
Copy link
Member

colinux commented Aug 22, 2024

@mfo ah non déso, je disais que la review contenait une remarque sur le pattern (avec les lettres)

Et indépendamment de ça , sinon je proposais de faire le strip JS sur le RNF

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (3796210) to head (76f9373).
Report is 14 commits behind head on main.

Files Patch % Lines
app/tasks/maintenance/normalize_rna_values_task.rb 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10708      +/-   ##
==========================================
+ Coverage   80.29%   84.63%   +4.33%     
==========================================
  Files        1253     1118     -135     
  Lines       26623    24738    -1885     
  Branches     4775     4600     -175     
==========================================
- Hits        21376    20936     -440     
+ Misses       5247     3802    -1445     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfo mfo added this pull request to the merge queue Aug 22, 2024
Merged via the queue into demarches-simplifiees:main with commit 8a42c6a Aug 22, 2024
18 checks passed
@mfo mfo deleted the US/format-rna branch August 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants