Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ instructeur, je souhaite acceder aux information liées à l'adresses des champs RNA/RNF/SIRET #10703

Merged

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Aug 21, 2024

Apres (pr les champs rna/rnf/siret) :
Capture d’écran 2024-08-21 à 11 09 06 AM

Avant (siret) :
Capture d’écran 2024-08-21 à 11 02 07 AM

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (8cdd7ef) to head (70983c5).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
app/models/address_proxy.rb 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10703      +/-   ##
==========================================
+ Coverage   80.26%   84.64%   +4.38%     
==========================================
  Files        1251     1118     -133     
  Lines       26582    24759    -1823     
  Branches     4764     4601     -163     
==========================================
- Hits        21335    20958     -377     
+ Misses       5247     3801    -1446     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfo mfo force-pushed the US/dry-rna-rnf-siret-addresses-view branch 2 times, most recently from 57b7e8e to 75dea57 Compare August 21, 2024 13:14
@mfo mfo changed the title ETQ instructeur, je souhaite acceder aux information liées à l'adresses des champs RNA/RNF/SIRET WIP – ETQ instructeur, je souhaite acceder aux information liées à l'adresses des champs RNA/RNF/SIRET Aug 21, 2024
@mfo mfo force-pushed the US/dry-rna-rnf-siret-addresses-view branch 4 times, most recently from d32e14f to 225074e Compare August 21, 2024 13:31
@mfo mfo changed the title WIP – ETQ instructeur, je souhaite acceder aux information liées à l'adresses des champs RNA/RNF/SIRET ETQ instructeur, je souhaite acceder aux information liées à l'adresses des champs RNA/RNF/SIRET Aug 21, 2024
Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top. Remarque sur CP/département et ce serait cool d'avoir un test qui teste succintement la nouvelle view (pour passer par le champ presenter)

config/locales/models/champs/normalized_address/fr.yml Outdated Show resolved Hide resolved
app/services/api_geo_service.rb Show resolved Hide resolved
app/models/address_proxy.rb Outdated Show resolved Hide resolved
app/models/address_proxy.rb Show resolved Hide resolved
@mfo mfo force-pushed the US/dry-rna-rnf-siret-addresses-view branch from 7e6f9fe to a1ab784 Compare August 22, 2024 07:17
@mfo mfo force-pushed the US/dry-rna-rnf-siret-addresses-view branch 2 times, most recently from b2b15f7 to 7182a4e Compare August 22, 2024 07:55
@mfo
Copy link
Contributor Author

mfo commented Aug 22, 2024

@colinux : ac la spec: d455099

@mfo mfo force-pushed the US/dry-rna-rnf-siret-addresses-view branch from d455099 to 29579d1 Compare August 22, 2024 08:26
@mfo mfo force-pushed the US/dry-rna-rnf-siret-addresses-view branch from 29579d1 to 70983c5 Compare August 22, 2024 08:37
@mfo mfo added this pull request to the merge queue Sep 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2024
@mfo mfo added this pull request to the merge queue Sep 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2024
@mfo mfo added this pull request to the merge queue Sep 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2024
@mfo mfo added this pull request to the merge queue Sep 2, 2024
Merged via the queue into demarches-simplifiees:main with commit f171727 Sep 2, 2024
18 checks passed
@mfo mfo deleted the US/dry-rna-rnf-siret-addresses-view branch September 2, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants