Correctif: ETQ admin, je souhaite pouvoir utiliser des champs public pour conditionner une annotation privée

[mfo]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (5ef29a2) to head (27b86f9).
Report is 27 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10503      +/-   ##
==========================================
- Coverage   80.89%   80.88%   -0.01%     
==========================================
  Files        1211     1211              
  Lines       25612    25635      +23     
  Branches     4623     4632       +9     
==========================================
+ Hits        20719    20736      +17     
- Misses       4893     4899       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[colinux]

pas tout pigé, mais d'après les tests ça a l'air bien ;)

[colinux]

tiens à l'occas on pourra essayer de refactorer cet enchainement pour éviter autant de boucles et allocations

[colinux]

peut-être que ça marche :

Suggested change

	tdcs
	.map.with_index
	.filter_map { |tdc, i| tdc.condition? ? [tdc, i] : nil }
	.map do |tdc, i|
	[tdc, tdc.condition.errors(public_tdcs.take(i))]
	[tdc, tdc.condition.errors(tdcs.take(i))]
	end
	.filter { |_tdc, errors| errors.present? }
	.each do |tdc, _error_hash|
	tdcs.each_with_index do |tdc, i|
	next unless tdc.condition?
	errors = tdc.condition.errors(tdcs.take(i))
	next if errors.blank?
	procedure.errors.add(
	attribute,
	procedure.errors.generate_message(attribute, :invalid_condition, { value: tdc.libelle }),
	type_de_champ: tdc
	)
	end

[colinux]

Suggested change

	it 'validates that types de champ private condition works types de champ public and private' do
	end