Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager): export administrators and instructeurs list #10489

Merged

Conversation

tchak
Copy link
Member

@tchak tchak commented Jun 4, 2024

Ajout de liens d'export des 6 derniers mois d'instructeurs et d'administrateurs créés sur la plateforme

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.95%. Comparing base (3376893) to head (1bc714a).

Files Patch % Lines
.../controllers/manager/administrateurs_controller.rb 25.00% 6 Missing ⚠️
app/controllers/manager/instructeurs_controller.rb 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10489      +/-   ##
==========================================
- Coverage   80.99%   80.95%   -0.04%     
==========================================
  Files        1233     1233              
  Lines       26082    26097      +15     
  Branches     4713     4713              
==========================================
+ Hits        21125    21128       +3     
- Misses       4957     4969      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tchak tchak force-pushed the feat-export-administration-info branch 2 times, most recently from 7b33e72 to 7bf6083 Compare June 6, 2024 14:01
@colinux
Copy link
Member

colinux commented Jun 11, 2024

Je pose la question : est-ce qu'on ne voudrait pas le même système d'autorisation par un pair qu'on a pour devenir admin d'une démarche ? (vu que c'est notre workflow actuel à la main)

EDIT: après discussions on mettra la confirmation en place dans une future PR

@tchak tchak force-pushed the feat-export-administration-info branch from 7bf6083 to 1bc714a Compare July 2, 2024 09:07
@colinux colinux added this pull request to the merge queue Jul 2, 2024
Merged via the queue into demarches-simplifiees:main with commit d609b6b Jul 2, 2024
18 checks passed
@tchak tchak deleted the feat-export-administration-info branch July 16, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants