Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mise en place de l 'infrastructure de rejet d'envoi de mails non confirmés #10456

Merged
merged 6 commits into from
May 27, 2024

Conversation

LeSim
Copy link
Member

@LeSim LeSim commented May 27, 2024

Première partie de #10450

Copy link

what-the-diff bot commented May 27, 2024

PR Summary

  • Email Verification Date Captured
    The system can now record the time a user's email address was verified. This new feature is accomplished by adding a field called email_verified_at in both users and individuals data tables.

  • Email Verification Time Auto-Updated
    Enhancement is made to automatically update the email_verified_at time stamp when individuals and users confirm their emails, users are upgraded to instructor or expert roles.

  • Pre-filling Verification Time for Current Users
    For existing users and individuals, new scripts were added to prefill the email_verified_at field with the current time.

  • Default Users Email Verified
    The creation of new default users now comes with pre-verified email, marked with the creation time as verification time.

  • Verification Status Testing Enhanced
    Quality of the new feature is confirmed with advanced tests. The tests are specifically designed to confirm the presence of email_verified_at when a new user is confirmed, promoted, and when an individual is created or modified.

Please note that these changes are only applicable when someone's email address is verified and are saved in the database, meaning no impact on users' practical experience. The addition of the email_verified_at field just increases the depth of user data we have on record.

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 80.81%. Comparing base (dbfd5ee) to head (555df3a).

Files Patch % Lines
...nance/prefill_individual_email_verified_at_task.rb 0.00% 10 Missing ⚠️
...maintenance/prefill_user_email_verified_at_task.rb 0.00% 10 Missing ⚠️
app/models/user.rb 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10456      +/-   ##
==========================================
- Coverage   80.90%   80.81%   -0.09%     
==========================================
  Files        1205     1207       +2     
  Lines       25522    25544      +22     
  Branches     4597     4597              
==========================================
- Hits        20648    20644       -4     
- Misses       4874     4900      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

spec/models/user_spec.rb Show resolved Hide resolved
@LeSim LeSim force-pushed the infra_email_confirmation branch from eeebf91 to 555df3a Compare May 27, 2024 15:25
@LeSim LeSim enabled auto-merge May 27, 2024 15:25
@LeSim LeSim added this pull request to the merge queue May 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 27, 2024
@LeSim LeSim added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 0b60940 May 27, 2024
19 checks passed
@LeSim LeSim deleted the infra_email_confirmation branch May 27, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants